Ruff format and lint and tidy top-level #252
Merged
+218
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils in ruff The function of most of these is not clear but some of these are useful.
2 tasks
jeanconn
reviewed
Nov 29, 2023
| @@ -74,7 +74,7 @@ def sanitize_event_expression(expr): | |||
| ast.literal_eval(word) | |||
| tokens.append("LITERAL") | |||
| except Exception: | |||
| raise ValueError("Cannot identify word {!r}".format(word)) | |||
| raise ValueError("Cannot identify word {!r}".format(word)) from None | |||
There was a problem hiding this comment.
Does the "from None" in this context change the output here?
There was a problem hiding this comment.
Yes, but it is what we want.
jeanconn
approved these changes
Nov 29, 2023
This was referenced Jan 9, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a light application of ruff formatting and linting, meaning that quite a few rules are ignored in the interest of time and recognizing that test coverage might be low.
In addition I did some long-overdue tidying of the top-level directory. There were a bunch of random scripts that were rarely/never used, including a number of Python 2 scripts. These were moved into
dev_utils/ordev_utils/legacy_py2/. I also moved all theNOTES.*files into aNOTESdirectory.Interface impacts
Testing
Unit tests
Note: there is a warning in
cheta/cheta/tests/test_comps.py::test_mups_valverelated to being unable to get a version forSka.engarchive. This warning is not new to this PR, it shows up in master testing the same way.Independent check of unit tests by Jean
Functional tests
No functional testing.